From: Mike Taylor <mike@indexdata.com>
Date: Thu, 15 Mar 2007 11:40:27 +0000 (+0000)
Subject: Fix result-set leak.
X-Git-Tag: CPAN-v1.02~530
X-Git-Url: http://lists.indexdata.com/cgi-bin?a=commitdiff_plain;h=1dbac7da313ac8dcee78f2c2f415ee395cec2d86;p=irspy-moved-to-github.git

Fix result-set leak.
Abandon test early on error 235 (DB doesn't exist)
---

diff --git a/lib/ZOOM/IRSpy/Test/Search/Bib1.pm b/lib/ZOOM/IRSpy/Test/Search/Bib1.pm
index 4628f14..7dc644e 100644
--- a/lib/ZOOM/IRSpy/Test/Search/Bib1.pm
+++ b/lib/ZOOM/IRSpy/Test/Search/Bib1.pm
@@ -1,4 +1,4 @@
-# $Id: Bib1.pm,v 1.17 2007-02-28 17:32:48 mike Exp $
+# $Id: Bib1.pm,v 1.18 2007-03-15 11:40:27 mike Exp $
 
 # See the "Main" test package for documentation
 
@@ -33,8 +33,9 @@ sub start {
 sub found {
     my($conn, $task, $test_args, $event) = @_;
     my $attr = $test_args->{'attr'};
-    my $n = $task->{rs}->size();
 
+    my $n = $task->{rs}->size();
+    $task->{rs}->destroy();
     $conn->log("irspy_test", "search on access-point $attr found $n record",
 	       $n==1 ? "" : "s");
     update($conn, $attr, 1);
@@ -47,12 +48,14 @@ sub error {
     my($conn, $task, $test_args, $exception) = @_;
     my $attr = $test_args->{'attr'};
 
+    $task->{rs}->destroy();
     $conn->log("irspy_test", "search on access-point $attr had error: ",
 	       $exception);
     update($conn, $attr, 0);
 
     return ZOOM::IRSpy::Status::TEST_BAD
 	if ($exception->code() == 1 || # permanent system error
+	    $exception->code() == 235 || # Database does not exist
 	    $exception->code() == 109); # Database unavailable
 
     return ZOOM::IRSpy::Status::TASK_DONE;