Only reseting on position, when not done before. Otherwise it would reset on every...

[pazpar2-moved-to-github.git] / src / session.c

diff --git a/src/session.c b/src/session.c
index 0d463d6..6ac2276 100644 (file)
--- a/src/session.c
+++ b/src/session.c
@@ -620,7 +620,7 @@ int session_is_preferred_clients_ready(struct session *s)
 }
 
 static void session_clear_set(struct session *se,
-                              const char *sort_field, int increasing)
+                              const char *sort_field, int increasing, int position)
 {
     reclist_destroy(se->reclist);
     se->reclist = 0;
@@ -635,50 +635,48 @@ static void session_clear_set(struct session *se,
     se->sorted_results = nmem_malloc(se->nmem, sizeof(*se->sorted_results));
     se->sorted_results->field = nmem_strdup(se->nmem, sort_field);
     se->sorted_results->increasing = increasing;
+    se->sorted_results->position = position;
     se->sorted_results->next = 0;
     
     se->reclist = reclist_create(se->nmem);
 }
 
-void session_sort(struct session *se, const char *field, int increasing, int clear_set)
+void session_sort(struct session *se, const char *field, int increasing,
+                  int position)
 {
     struct session_sorted_results *sr;
     struct client_list *l;
 
     session_enter(se);
 
-    yaz_log(YLOG_LOG, "session_sort field=%s", field);
-    // TODO In order for this to work, clear_set may only be true on first call. Every following (poll) may not. 
-    // I do not think we can decide this from the outside of the session. 
-    // The logic should be when we change to/away from a native sort order, 
-    // it should cleared on the first call
-    if (clear_set)
+    yaz_log(YLOG_LOG, "session_sort field=%s increasing=%d position=%d", field, increasing, position);
+    /* see if we already have sorted for this critieria */
+    /* TODO I do not see the point in saving all previous sorts. Dont we re-sort anyway ? */
+    for (sr = se->sorted_results; sr; sr = sr->next)
     {
-        session_clear_set(se, field, increasing);
+        if (!strcmp(field, sr->field) && increasing == sr->increasing && sr->position == position)
+            break;
     }
-    else
+    if (sr)
     {
-        /* see if we already have sorted for this critieria */
-        for (sr = se->sorted_results; sr; sr = sr->next)
-        {
-            if (!strcmp(field, sr->field) && increasing == sr->increasing)
-                break;
-        }
-        if (sr)
-        {
-            session_log(se, YLOG_DEBUG, "search_sort: field=%s increasing=%d already fetched",
-                        field, increasing);
-            session_leave(se);
-            return;
-        }
-        session_log(se, YLOG_DEBUG, "search_sort: field=%s increasing=%d must fetch",
-                    field, increasing);
-        sr = nmem_malloc(se->nmem, sizeof(*sr));
-        sr->field = nmem_strdup(se->nmem, field);
-        sr->increasing = increasing;
-        sr->next = se->sorted_results;
-        se->sorted_results = sr;
+        session_log(se, YLOG_DEBUG, "search_sort: field=%s increasing=%d position=%d already fetched",
+                    field, increasing, position);
+        session_leave(se);
+        return;
     }
+    if (position)
+    {
+        session_clear_set(se, field, increasing, position);
+    }
+
+    session_log(se, YLOG_DEBUG, "search_sort: field=%s increasing=%d position=%d must fetch",
+                field, increasing, position);
+    sr = nmem_malloc(se->nmem, sizeof(*sr));
+    sr->field = nmem_strdup(se->nmem, field);
+    sr->increasing = increasing;
+    sr->position = position;
+    sr->next = se->sorted_results;
+    se->sorted_results = sr;
         
     for (l = se->clients_active; l; l = l->next)
     {
@@ -698,7 +696,8 @@ enum pazpar2_error_code session_search(struct session *se,
                                        const char *filter,
                                        const char *limit,
                                        const char **addinfo,
-                                       const char *sort_field, int increasing)
+                                       const char *sort_field,
+                                       int increasing)
 {
     int live_channels = 0;
     int no_working = 0;
@@ -719,7 +718,7 @@ enum pazpar2_error_code session_search(struct session *se,
     
     session_enter(se);
     se->settings_modified = 0;
-    session_clear_set(se, sort_field, increasing);
+    session_clear_set(se, sort_field, increasing, 0); /* hardcoded position */
     relevance_destroy(&se->relevance);
 
     live_channels = select_targets(se, filter);